Do not ignore the test on MSVC #30921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r- So it indeed fails. We have an issue with our translation, then. |
|
I guess I’ll fix the underlying issue and reenable this test in my other PR, since I’m fixing it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sprintfis indeed not a proper function in VS 2015, but there’s a equivalentwsprintfAfunction in the user32, which can be used.I’m primarily submitting this PR to see what happens on the 64bit MSVC buildbot, so I have less things to check once I summon a Windows machine for failures on #30845. If this PR fails to land, then we possibly mistranslate variadic functions for MSVC target. If this PR passes, I can be sure the issue there is restricted to MIR translator and reduce my debugging workload considerably.
r? @alexcrichton